feat: adding clickble symbol render in chat panel #3420
+265
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsxiaoys
reviewed
Nov 17, 2024
wsxiaoys
reviewed
Nov 17, 2024
wsxiaoys
reviewed
Nov 17, 2024
wsxiaoys
changed the title
wsxiaoys
reviewed
Nov 18, 2024
|
Need handle cases that certain backend doesn't support such feature (e.g IntelliJ) |
Sma1lboy
force-pushed
the
feat-adding-clickble-keywords-chat-panel
branch
from
ddcbe91
to
c3d0709
Compare
The code changes in `ChatPage` component add support for the `onNavigateSymbol` and `onHoverSymbol` capabilities. These capabilities are checked and set using the `hasCapability` method of the server. The `onNavigateSymbol` and `onHoverSymbol` methods are conditionally used based on the support for these capabilities. This change enhances the functionality of the ChatPage component in the Tabby UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
onNavigateSymbolwith rendered inline blocks.onHoverSymbolwith rendered inline blocks.ClientApimethods are handled by a capability check.onNavigateSymbolis not exposed.Go to definitiontitle will not be shown ifonHoverSymbolis not implemented.Demo
Screen.Recording.2024-11-30.at.06.37.15.mov